Finishing Short Truth Table Contradiction Rule tests - Githubissues

Bram-Hub / LEGUP

Logic Engine for Grid-Using Puzzles - a better way to learn formal logic

GNU General Public License v3.0

33 stars 82 forks source link

Finishing Short Truth Table Contradiction Rule tests #713

Closed charlestian23 closed 6 months ago

charlestian23 commented 8 months ago

Description

This pull request adds tests for the remaining contradiction rules in Short Truth Table.

Closes #652, #653, #654 , #655, #656, #657

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Enhancement (improvement to an already existing feature)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (if applicable)
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Chase-Grajeda commented 7 months ago

@Bram28 Could you review the test logic? Will be merged next week