After seeing the errors thrown by the auto-formatter in #776, I changed the auto-formatter's behavior:
For pull requests into dev, the auto-formatter functions the same, though the method used for detecting formatting changes has been improved.
For pull requests from dev, the auto-formatter will check if there are formatting changes that are necessary. Then, if there are formatting changes, the auto-formatter will open a new pull request with those changes into dev. This is because of branch protections, as the auto-formatter doesn't have permissions to directly push onto dev.
Note: The changes to GridRegion.java were made by the auto-formatter.
Type of change
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Enhancement (improvement to an already existing feature)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
How Has This Been Tested?
I tested these changes in my fork by mimicking the permissions of master and dev. I then created bad formatting commits both to and from dev to ensure that these changes work.
Checklist:
[x] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (if applicable)
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
Description
After seeing the errors thrown by the auto-formatter in #776, I changed the auto-formatter's behavior:
dev
, the auto-formatter functions the same, though the method used for detecting formatting changes has been improved.dev
, the auto-formatter will check if there are formatting changes that are necessary. Then, if there are formatting changes, the auto-formatter will open a new pull request with those changes intodev
. This is because of branch protections, as the auto-formatter doesn't have permissions to directly push ontodev
.Note: The changes to
GridRegion.java
were made by the auto-formatter.Type of change
How Has This Been Tested?
I tested these changes in my fork by mimicking the permissions of
master
anddev
. I then created bad formatting commits both to and fromdev
to ensure that these changes work.Checklist: