Bram-Hub / LEGUP

Logic Engine for Grid-Using Puzzles - a better way to learn formal logic
GNU General Public License v3.0
34 stars 82 forks source link

[BUG] Deleting Node from Merged Tree #863

Open jadeandtea opened 1 month ago

jadeandtea commented 1 month ago

Description

When deleting a node from a branch from the tree that has been merged farther ahead, the program does not know what to do.

Steps to Reproduce

  1. Choose a case rule that create multiple branches, such as Nurikabe White or Black.

  2. Make a step in both of the branches. The move doesn't have to be valid, and the resulting cell(s) does not have to be the same between the branches.

  3. Merge the two branches. There does not have to be any similar tiles; the program should allow for this type of branch --> merge.

    Screenshot 2024-10-08 at 5 07 04 PM
  4. Delete one of the nodes on either branch.

    Screenshot 2024-10-08 at 5 07 30 PM

Expected Behavior

When deleting the node, it should delete all nodes in front of it, including the merged node.

Screenshots

No response

Puzzle Files

No response

Additional Context

No response

ADEPLI commented 1 month ago

Has there been an update that modified the program's behavior? The program seems to be trying to delete the node in front, although there is a visual glitch with the arrows and sometimes the node not completely updating. I don't see any commits that would have addressed this issue, but the behavior seems to have changed. Does it still appear the same for everyone else?

  1. Original State

    image
  2. After Deleting Previous Node

    image