Bram1903 / AntiHealthIndicator

Enhance fairness with AntiHealthIndicator! Lightweight, async packet spoofing for gameplay integrity. Easy configurable!
https://discord.deathmotion.com
GNU General Public License v3.0
30 stars 5 forks source link

[Bug] Strange freezing/lag #7

Closed ewof closed 3 months ago

ewof commented 5 months ago

some players report a mini rubberbanding / screen freezing for a second with this plugin, had to go 1 by 1 to see what caused and somehow it was this plugin. i know this isn't really helpful so if there's any relevant info i can give you just ask, also it doesn't happen to me but it happens to a good amount of players. its only clientside

Bram1903 commented 5 months ago

Hey there,

Thanks for reporting this issue! I'm am trying to figure out what could be causing these freeze ups as everything is being done asynchronous away from the main thread, but on the other side this sounds like a client side glitch, not necessarily performance. What version and software is your server running and are you using any plugins like ViaVersion?

ewof commented 5 months ago

we're on git-Folia-"25ee657" with velocity, we have via version with the packet limiters disabled. to some people it doesnt happen but it happens to some people even on a vanilla minecraft client with no mods

Bram1903 commented 5 months ago

Alright thank you so much! Since today I'm on vacation and I will be back Thursday. I'll try to find a fix this evening on my MacBook!

ewof commented 5 months ago

thank u so much for looking into it. there's no rush so you should enjoy your vacation if youd prefer, i dont want to pressure you or anything haha

Bram1903 commented 5 months ago

I can't quickly find the problem for now. I will look into this more deeply soon!

Bram1903 commented 5 months ago

This is still on the roadmap, I am just having a hard time finding the time to patch issues. :-)

Bram1903 commented 5 months ago

Hey @ewof,

I am having a hard time trying to find/reproduce this issue. Technically I am only modifying already sent packets, not necessarily delaying or sending extra packets. Therefore I don't understand how this could create rubber banding issues.

I asked some of my friends at PacketEvents if they knew what could cause this issue, and they are saying my plugin is almost impossible to cause such an issue. Do you perhaps have more information? What kind of people are experiencing issues (extremely bad PC?), etc?

The only thing I could think of is that on your server many people are constantly mounting and unmounting vehicles (like A LOT), but that chance is pretty small. I did patch an issue with that a few days ago, because I was creating and sending the packet on the main listener thread, thus slightly blocking the netty thread.

Kind regards, Bram

Bram1903 commented 4 months ago

@ewof, could you try out the latest version 2.1.0 (make sure to update your PacketEvents), and tell me if the issue still occurs?

ewof commented 4 months ago

it doesn't happen to me but when they're online i'll check with the people who were having the issue

ewof commented 4 months ago

still happens

Bram1903 commented 4 months ago

Hello @ewof,

Sorry for the long delay. I have been quite busy these past weeks. I am currently working on adding proxy support for both Velocity and Bungeecord (including any forks). Besides that, I added native Folia scheduler support. I hope this somehow solves your issues.

I am not yet sure when I will release this new version as there are still a few complex matters I have to resolve when running this on the proxy, but I am sure we will manage. I thought I'd give you a quick update for now.

Kind regards, Bram

Bram1903 commented 3 months ago

Hey @ewof,

Can you try the latest release: https://github.com/Bram1903/AntiHealthIndicator/releases/tag/v2.2.0

It has countless improvements and is much faster than the previous one!

Kind regards, Bram

ewof commented 3 months ago

still happens but on previous versions it was a full freeze and now it's just an FPS drop (but still noticeable)

Bram1903 commented 3 months ago

still happens but on previous versions it was a full freeze and now it's just an FPS drop (but still noticeable)

I just don't get it. My plugin simply cannot cause any decrease in performance. Everything that is being done, is done on the server. A client freezing up or having worse FPS is just not possible. My plugin cannot influence that. Sorry, but I can't fix this issue for you.

Kind regards, Bram