search

Bram28 / LEGUP

Logic Engine for Grid-Using Puzzles - a better way to learn formal logic
GNU Affero General Public License v3.0
2 stars 8 forks source link

Nurikabe: Isolated Black rule #60

Closed Bram28 closed 9 years ago

Bram28 commented 9 years ago

The Isolated Black rule does not seem to take edges into account.

Also: we should also have a Isolated White rule: if some region is surrounded by all white (and there is at least one black outside of that region), then it self should be white as well

knaik95 commented 9 years ago

I can't find the code that deals with this rule. Does this need a new class? (i.e. RuleIsolatedBlack.java)

Bram28 commented 9 years ago

Sorry, I meant the Black Must Connect contradiction rule. It’s there, but it has a bug. It seems like it is only checking for all whites around black, and it forgets to take into account the edge. Do you think you can try and fix that?

Bram From: knaik95 [mailto:notifications@github.com] Sent: Thursday, October 16, 2014 2:25 PM To: Bram28/LEGUP Cc: Van Heuveln, Bram Subject: Re: [LEGUP] Nurikabe: Isolated Black rule (#60)

I can't find the code that deals with this rule. Does this need a new class? (i.e. RuleIsolatedBlack.java)

— Reply to this email directly or view it on GitHubhttps://github.com/Bram28/LEGUP/issues/60#issuecomment-59406888.

Bram28 commented 9 years ago

Also, I now realize I was confusing the Black Must Connect with the Fill in Black rule when I said we need this rule also for White. What I meant is that we need a Fill in White rule. Any takers?

Bram28 commented 9 years ago

OK, I just created a separate issue (#61) for the Fill in White rule.

saltzl commented 9 years ago

Doesn't apply correctly if there are no other black squares outside of surrounded region

saltzl commented 9 years ago

Fixed