search

Bram28 / LEGUP

Logic Engine for Grid-Using Puzzles - a better way to learn formal logic
GNU Affero General Public License v3.0
2 stars 8 forks source link

Rectangular Boards: Source of Errors? #73

Closed Bram28 closed 9 years ago

Bram28 commented 9 years ago

Rectangular boards seem to cause some errors ... in Nurikabe at least ... other puzzles?

mmellone commented 9 years ago

I discovered it was some old rules that used cells[x][y] instead of cells[y][x], this flipped the width and height and thus caused index out of bounds errors with the rectangular boards. I changed these rules (fill in black, fill in white, and surround region) to use contradictions like the other rules. It also saved a few hundred lines of code and probably made them run a little faster (some of the old algorithms were a little costly I believe), so it was a good change.

1fc21fedac267c8989f9c2cac3fa638cd0694d90

Bram28 commented 9 years ago

Nijce, good work!!

Bram

From: Mitchell Mellone [notifications@github.com] Sent: Friday, February 06, 2015 5:36 PM To: Bram28/LEGUP Cc: Van Heuveln, Bram Subject: Re: [LEGUP] Rectangular Boards: Source of Errors? (#73)

I discovered it was some old rules that used cells[x][y] instead of cells[y][x], this flipped the width and height and thus caused index out of bounds errors with the rectangular boards. I changed these rules (fill in black, fill in white, and surround region) to use contradictions like the other rules. It also saved a few hundred lines of code and probably made them run a little faster (some of the old algorithms were a little costly I believe), so it was a good change.

1fc21fehttps://github.com/Bram28/LEGUP/commit/1fc21fedac267c8989f9c2cac3fa638cd0694d90

� Reply to this email directly or view it on GitHubhttps://github.com/Bram28/LEGUP/issues/73#issuecomment-73325924.