[GB-204] Addon for ReShade 6.0.0 has issues

[BramTeurlings]

After testing the addon we discovered the following:

• The addon causes stutter while weaving in DX12 (Elden Ring)
• The addon causes a black screen while weaving DX11 (Hitman 2)

We didn’t see any issues in DX9 but we should investigate this all the same. Perhaps testing with Crosire’s new built-in descriptor head reset would be better?

We should test next week.

---

Originally reported by , imported from: Addon for ReShade 6.0.0 has issues

• assignee:
• status: Closed
• priority: Medium
• resolution: Fixed
• resolved: 2024-02-02T00:42:18-08:00
• imported: 2024-04-04

[BramTeurlings]

Subtask of parent task GB-190

[BramTeurlings]

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

Issues seen with new 6.0.0 addon release:

• Black screen when weaving
  • Might be due to HDR?
• I see the last pre-HDR frame stuck in the weaver when toggling HDR from ON to OFF in Hitman 2
• Changing the monitor color format seems to fix it?
• May have been my bad, I did not have the right reshade installed. Weaving works fine in DX11 now but the game crashes when you arrive on the menu. This is probably due to ReShade's update.
• Stutter in-game while weaving
• Only happens with SD3D turned on

[BramTeurlings]

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

Let's test the new master of ReShade, use Crosire’s new fix and see if our issues go away.

We can replace the dll in the installer with the one we build locally.

Furthermore we can remove our descriptor heap code and try testing again to see if the issues go away.

[BramTeurlings]

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

Try with ReShade 6.0.1 and Crosire’s new method.

[BramTeurlings]

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

Observations:

• The jitter still occurs when FXAA.fx is turned off
• The jitter happens only when you are moving the camera
• Jitter is not visible in Asphalt 9
• Jitter is not visible in SoTTR DX12
• It could be a game-specific issue, perhaps DRM/Anti-Cheat remnants?
  • It does NOT happen with srReshade_5.8.0_1.26.2
• After removing the code Joey added to better handle resource destruction the problem no longer occurs. Looking into the direct cause now.

It ended up being the new buffer deletion code that causes the strange jittering. I replaced it with a GPU wait when the buffer is resized which is a bit slower but should only occur on one frame when resizing so it’s much better in the long run,

[BramTeurlings]

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

MR: https://github.com/JoeyAnthony/3DGameBridgeProjects/pull/17

[BramTeurlings]

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

It looks like the weaver instance becomes destroyed when I toggle weaving/SD3D on and off in DX12. I should look into this tomorrow.

[BramTeurlings]

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

I made a workaround for the crashes, testing the addon now to see if it’s stable again. Games tested:

• Hitman 2
• SoTTR
• Elden Ring
• Street fighter 6
• Nier Automata
• FFVII Remake
• Trine 3

I believe that this addon is now stable. I will make a small change to include a new shader called “SR.fx” which does nothing but ensures we can always weave. Crosire has made this fix obsolete in a new version but for now it is required.

[BramTeurlings]

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

I’ve made a small shader called SR.fx that serves as a simple shader to activate the effect pipeline in ReShade. I’ll attach it as part of the release tag on GitHub

[BramTeurlings]

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

Tested with 7-8 games, hasn't crashed so seems very stable. New features seem to also work.

[BramTeurlings]

607809585759fb0069a89817:

Reviewed the code

[BramTeurlings]

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

Tested the addon in 7-8 different games with different Graphics APIs. It seems stable and some games that were crashing before now suddenly work with ReShade 6.0.1

[BramTeurlings]

[Epic: srReshade addon]