BramTeurlings / 3DGameBridge

Wrapper Project for easy implementation of function in any 3D Game Bridge project
GNU General Public License v3.0
3 stars 1 forks source link

[GB-203] Addon crashes when no SR Service is active #48

Closed BramTeurlings closed 9 months ago

BramTeurlings commented 9 months ago

We need to inform the user that no service is active in our addon settings instead of crashing.


Originally reported by , imported from: Addon crashes when no SR Service is active
  • assignee:
  • status: Closed
  • priority: Medium
  • resolution: Fixed
  • resolved: 2024-02-02T00:47:58-08:00
  • imported: 2024-04-04
BramTeurlings commented 9 months ago

Subtask of parent task GB-190

BramTeurlings commented 9 months ago

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

Made a merge request here: https://github.com/JoeyAnthony/3DGameBridgeProjects/pull/16

BramTeurlings commented 9 months ago

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

Tested after rebasing on GB-204 Closed . Works well, added a status message in the addon tab under our addon. It is red when something is wrong with the service or the chosen graphics API.

BramTeurlings commented 9 months ago

607809585759fb0069a89817:

Code is good

BramTeurlings commented 9 months ago

712020:c26664a4-c3de-4473-a0b4-5a76804d5628:

Tested in DX9/11/12 service being unavailable no longer crashes the game and the new error handling in the addon tab works and looks nice.

BramTeurlings commented 7 months ago

[Epic: srReshade addon]