Bramas / Ultratools

Editor for Ultrastar songs
5 stars 5 forks source link

Three new Features for your tool #4

Closed palsch closed 1 year ago

palsch commented 8 years ago

Hello, I would like to ask you if you can import these three features in your official tool:

These new features increases the working performance with your tool, specifically the copy and paste feature.

Bramas commented 8 years ago

Hello, sorry for being late to the conversation! Thanks for the new features and for taking time to implement it.

So, if I understand well, there is a problem with mp3 files that contain special character, because when you read the txt file, you may not read the mp3 filename correctly? or is it a problem with FMOD?

@s09bQ5 is right, we have to try opening the txt file with utf8 first, but if there is an encoding tag, or no encoding tag but we detect wrong characters, then we open it with another encoding. Then when we save, I don't kwow if its ok to change the encoding of the file without asking for the user (actually I'm ok with it), If yes, I'm ok to add the encoding tag to utf-8 for every file we save. However I would not put a BOM when saving, at least not to bother the other software that open the file and may not handle well BOM/utf8.

For playing the note while translating, I prefer not to play the not for every not (resulting, as you said, as only the last one being actually played). Instead I think it is better to remove this line and add after the for loop something like:

    Word firstSelectedWord = _selectedWords.begin().key();
    UNoteManager::Instance.play_with_timeout(firstSelectedWord);

because the selection contains the new words.

Also, for the copy-cut feature, I haven't tried it yet, but this seems really nice :+1: . I would just replace the condition checking _control_key_down by event->modifiers() == Qt::ControlModifier

legluondunet commented 6 years ago

Hello, I'm using Ultratools to write my txt song files and one of the feature that mess the more is copy/paste. Do you plan to add this feature?

legluondunet commented 1 year ago

Hello @palsch , I saw you just closed this pull request, do you still use Ultratools? The copy/paste feature miss me. It is for me the more practice software to write ultrastar karaoke files. It's a pity this project is discontinued.