search

BramvdnHeuvel / Rickroll-Generator

This website allows users to create their own rickrolls with links that no-one could recognize. Including rich preview for extra deceit on websites that use rich preview.
MIT License
64 stars 33 forks source link

div overflowing fix and others... #5

Open NihalNavath opened 3 years ago

NihalNavath commented 3 years ago

Fixed div overflowing causing it to be scrollable and centered credit text.

also is there a reason why embedded style sheets are not used and rules are directly specified in html?

BramvdnHeuvel commented 3 years ago

The reason that style sheets aren't used, is that the CSS style has been quite minimal for a long time. We could move the style to a CSS sheet now.

The code looks good to me! I'll test it locally when I get home, but I think it'll work fine.

BramvdnHeuvel commented 3 years ago

Though the links definitely look nicer on desktop and mobile, they may overlap on some devices. The iPhone 6/7/8 with iOS 11 has this issue on landscape mode, for example - most smartphones and tablets experience this issue in landscape mode.

Could you make it so the user has to scroll down to the credits if their screen has this problem? afbeelding

NihalNavath commented 3 years ago

Oh, 😳 my bad, forgot to check responsiveness, not home right now will open a PR implementing fix soon.

BramvdnHeuvel commented 2 years ago

Are you home yet? 😉