BranchMetrics / android-branch-deep-linking-attribution

The Branch Android SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/pages/apps/android/
MIT License
399 stars 156 forks source link

Add new field is_meta_ct field to v1/installs for Meta Install Referrer #1174

Closed nsingh-branch closed 6 months ago

nsingh-branch commented 6 months ago

Description

The server actually needs to know if a Meta Install Referrer was a click-through or view-through, so we need to pass it through in the install request. To do this, we create a new field in install requests called is_meta_ct. It will only be included in installs where a Meta Install Referrer is being attached as well.

Testing Instructions

Check that the field is being included in the request only when necessary and accurately. Also ensure no other logic is being broken by this change.

Risk Assessment [LOW]

Reviewer Checklist (To be checked off by the reviewer only)

cc @BranchMetrics/saas-sdk-devs for visibility.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 38.04%. Comparing base (53e1788) to head (465a120).

:exclamation: Current head 465a120 differs from pull request most recent head cb0a21e. Consider uploading reports for the commit cb0a21e to get more accurate results

Files Patch % Lines
...a/io/branch/referral/ServerRequestInitSession.java 0.00% 4 Missing :warning:
...K/src/main/java/io/branch/referral/PrefHelper.java 0.00% 3 Missing :warning:
...main/java/io/branch/referral/AppStoreReferrer.java 0.00% 2 Missing :warning:
...c/main/java/io/branch/referral/SystemObserver.java 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1174 +/- ## ============================================ - Coverage 38.08% 38.04% -0.04% Complexity 686 686 ============================================ Files 59 59 Lines 6270 6279 +9 Branches 937 939 +2 ============================================ + Hits 2388 2389 +1 - Misses 3436 3444 +8 Partials 446 446 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.