Closed nsingh-branch closed 6 months ago
Attention: Patch coverage is 45.00000%
with 11 lines
in your changes are missing coverage. Please review.
Project coverage is 38.03%. Comparing base (
1b6bb47
) to head (ac98a07
). Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
...in/java/io/branch/referral/TrackingController.java | 33.33% | 7 Missing and 3 partials :warning: |
...h-SDK/src/main/java/io/branch/referral/Branch.java | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Reference
SDK-2325 -- Add callback to disableTracking()
Description
This change adds a new callback to the
disabledTracking()
method that returns the new tracking state, the referring params, and an error. If tracking is disabled, only the tracking state will be returned. If tracking is enabled, it will also return the referringParams and any potential errors from the Branch session initialization.This change is useful for delayed initialization situations where tracking is initially disabled and the re-enabling of tracking is the first Branch initialization call.
Testing Instructions
Call the
disableTracking()
method without and with the callback and observe that all of the returned variables are correct.Risk Assessment [
LOW
]Reviewer Checklist (To be checked off by the reviewer only)
cc @BranchMetrics/saas-sdk-devs for visibility.