Closed nsingh-branch closed 3 months ago
Attention: Patch coverage is 40.90909%
with 13 lines
in your changes are missing coverage. Please review.
Project coverage is 38.28%. Comparing base (
83cf93a
) to head (c56248f
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Reference
SDK-2329 -- Support setting Branch API URL in Branch.json
Description
Added a new field to branch.json for setting the Branch API URL. The config check and setAPIUrl call are done in the getAutoInstance in the same place as the deferInitForPluginRuntime() check. One quirk is that all of the base URL's are stored with a "/" at the end, so we need to add that to the provided URL when making the setAPIUrl call. We don't want to have a URL ending with a "/" in the branch.json itself though since on iOS, the base URLs are stored without the "/".
Testing Instructions
Add
"apiUrl": "https://api.branch.io"
to a branch.json file and observe the API URL properly change for each request.Risk Assessment [
LOW
]Reviewer Checklist (To be checked off by the reviewer only)
cc @BranchMetrics/saas-sdk-devs for visibility.