BranchMetrics / android-branch-deep-linking-attribution

The Branch Android SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/pages/apps/android/
MIT License
399 stars 156 forks source link

[SDK-2444] Support for setting FB App ID through branch.json #1198

Closed nsingh-branch closed 3 months ago

nsingh-branch commented 4 months ago

Reference

SDK-2444 -- Support setting FB App ID through branch.json

Description

To support Meta Install Referrers on plugins, we need to enable clients to set the FB App ID before the install request is sent. Instead of using setFBAppId() directly, clients can now set it in the branch.json file.

This update also resolves a minor bug where setAPIUrl() was called every time, resulting in a warning message: "setAPIUrl: URL cannot be empty or null". This issue occurred because the method was invoked every time the JSON was checked, even if it was empty. Now, setAPIUrl() is only called when apiUrl is present in branch.json

Testing Instructions

Set fbAppId in branch.json and check if its being proper set and used.

Risk Assessment [LOW]

Reviewer Checklist (To be checked off by the reviewer only)

cc @BranchMetrics/saas-sdk-devs for visibility.