BranchMetrics / android-branch-deep-linking-attribution

The Branch Android SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/pages/apps/android/
MIT License
399 stars 156 forks source link

Reinstallation workflow Fix #1199

Closed NidhiDixit09 closed 4 months ago

NidhiDixit09 commented 4 months ago

Reference

QSS-112 - Reinstallation Scenario https://branch.atlassian.net/browse/QSS-112

Description

Re-installation test was failing, when ran using Github action, because of extra quotes in envirnoment variables and missing check for signing.

Testing Instructions

Run appium tests and validate that Re-installation test runs. However, with current branch test is ineffective, because SDK and Automation Test Bed binaries are exactly same to the one in master branch. So browserstack will not load binary from this branch. Its a duplicate binary. In order to pass test, make some changes in SDK and then run.

Example : I had added a variable and initalized it. So that binary in this branch is not duplicate to the one in master branch.

private final int test;

DeviceInfo(Context context) {
        context_ = context;
        systemObserver_ = new SystemObserverInstance();
        test = 123;
    }

Risk Assessment [HIGH || MEDIUM || LOW]

LOW

Reviewer Checklist (To be checked off by the reviewer only)

cc @BranchMetrics/saas-sdk-devs for visibility.

gdeluna-branch commented 4 months ago

So browserstack will not accept duplicate uploads? What is the error you get from the upload response?

NidhiDixit09 commented 4 months ago

Browserstack doesnt return any error - it simply returns same APP_URL. So NEW_APP_URL = OLD_APP_URL. And when test runs, it re-installs app with same app_url (which is already installed). So instead of a re-install, its an app open.

NidhiDixit09 commented 4 months ago

@gdeluna-branch I have also updated description. Updated linetest will fail to test is ineffective,.