BranchMetrics / android-branch-deep-linking-attribution

The Branch Android SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/pages/apps/android/
MIT License
399 stars 156 forks source link

R8: Missing class com.android.billingclient.api.BillingClient$Builder #1200

Closed keechan-kurly closed 1 month ago

keechan-kurly commented 3 months ago

Describe the bug

ERROR: R8: Missing class com.android.billingclient.api.BillingClient$Builder (referenced from: io.branch.referral.BillingGooglePlay io.branch.referral.BillingGooglePlay$Companion.getInstance())
Missing class com.android.billingclient.api.BillingClient (referenced from: com.android.billingclient.api.BillingClient io.branch.referral.BillingGooglePlay.billingClient and 5 other contexts)
Missing class com.android.billingclient.api.BillingClientStateListener (referenced from: void io.branch.referral.BillingGooglePlay.startBillingClient(kotlin.jvm.functions.Function1) and 1 other context)
Missing class com.android.billingclient.api.BillingResult (referenced from: void io.branch.referral.BillingGooglePlay$startBillingClient$1.onBillingSetupFinished(com.android.billingclient.api.BillingResult))
Missing class com.android.billingclient.api.ProductDetailsResponseListener (referenced from: void io.branch.referral.BillingGooglePlay.logEventWithPurchase(android.content.Context, com.android.billingclient.api.Purchase))
Missing class com.android.billingclient.api.Purchase (referenced from: void io.branch.referral.BillingGooglePlay.createAndLogEventForPurchase(android.content.Context, com.android.billingclient.api.Purchase, java.util.List, io.branch.referral.util.CurrencyType, double, java.lang.String) and 3 other contexts)
Missing class com.android.billingclient.api.PurchasesUpdatedListener (referenced from: com.android.billingclient.api.PurchasesUpdatedListener io.branch.referral.BillingGooglePlay.purchasesUpdatedListener and 3 other contexts)
Missing class com.android.billingclient.api.QueryProductDetailsParams$Builder (referenced from: void io.branch.referral.BillingGooglePlay.logEventWithPurchase(android.content.Context, com.android.billingclient.api.Purchase))
Missing class com.android.billingclient.api.QueryProductDetailsParams$Product$Builder (referenced from: void io.branch.referral.BillingGooglePlay.logEventWithPurchase(android.content.Context, com.android.billingclient.api.Purchase))
Missing class com.android.billingclient.api.QueryProductDetailsParams$Product (referenced from: void io.branch.referral.BillingGooglePlay.logEventWithPurchase(android.content.Context, com.android.billingclient.api.Purchase))
Missing class com.android.billingclient.api.QueryProductDetailsParams (referenced from: void io.branch.referral.BillingGooglePlay.logEventWithPurchase(android.content.Context, com.android.billingclient.api.Purchase))

Steps to reproduce

  1. AGP version is 8.6
  2. Build the app(./gradlew assembleRelease)

Expected behavior

BUILD SUCCESS

SDK Version

5.12.0

Make and Model

none

OS

none

Additional Information/Context

We solved it temporarily by adding a proguard rule.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale due to inactivity for 60 days. If this issue is still relevant, please respond with any updates or this issue will be closed in 7 days. If you believe this is a mistake, please comment to let us know. Thank you for your contributions.

github-actions[bot] commented 1 month ago

This issue has been closed due to inactivity. If this issue is still relevant, please reopen it or create a new one. Thank you for your contributions.