search

BranchMetrics / branch-deep-linking-public-api

The Branch Metrics public API for mobile deep linking / deeplinking applications. Branch helps mobile apps grow with deep links / deeplinks that power referral systems, sharing links and invites with full attribution and analytics.
https://dev.branch.io/references/http_api/
145 stars 18 forks source link

Branch-Public-API Updates #8

Closed LisaStucky closed 9 years ago

LisaStucky commented 9 years ago

I've updated per our discussion. In the first paragraph, I need to replace the bullets with steps, and I need to add underscores. I'm reviewing the markdown guide now.

LisaStucky commented 9 years ago

Hi Alex, I implemented all of your edits. I even added steps, underscores, and links in the markdown language. I've saved my changes, and now I want to do a Pull Request. I just want to double check: Do I click on the Merge pull request green button?

aaustin commented 9 years ago

Hey Lisa - This is already a pull request! Once you make it for one branch, you never have to make it again. If you click the green merge, it will push it live. Let me do one final review, then when I approve, I'll give you a :+1:

LisaStucky commented 9 years ago

Hi Alex, okay very good. I'm glad I didn't click that button. :) Although, I did save and then I clicked sync. Was that okay?

aaustin commented 9 years ago

That's totally fine - did you sync the public API? I don't see any changes here yet

LisaStucky commented 9 years ago

Oh, I guess I didn't sync the public api. Okay, let me find that.

LisaStucky commented 9 years ago

I just click sync again to make sure. Yet, I don't see it in the history. I think I'm missing a step. I saved my changes in Mac Down, and then I went to BranchMetrics/Branch-Public-API and clicked the sync icon (located in the top, right corner).

aaustin commented 9 years ago

Did you remember label the changes with a title and press commit first?

On Fri, Jun 5, 2015 at 10:25 PM, LisaStucky notifications@github.com wrote:

I just click sync again to make sure. Yet, I don't see it in the history. I think I'm missing a step. I saved my changes in Mac Down, and then I went to BranchMetrics/Branch-Public-API and clicked the sync icon (located in the top, right corner).

— Reply to this email directly or view it on GitHub https://github.com/BranchMetrics/Branch-Public-API/pull/8#issuecomment-109530996 .

LisaStucky commented 9 years ago

Thank you for that. Okay, it went through this time.

aaustin commented 9 years ago

:+1: