BranchMetrics / capacitor-branch-deep-links

Capacitor plugin for branch.io deep links
MIT License
33 stars 43 forks source link

Capacitor BranchDeepLinks.addListener is not working as a listener #127

Open GiannisS opened 4 months ago

GiannisS commented 4 months ago

Describe the bug

The addListener function is not working as a listener meaning that if new refferingParams arrive to App you will have to call again the BranchDeepLinks.addListener function in order to read them.

Steps to reproduce

Just initialize

        BranchDeepLinks.addListener("init", (event: BranchInitEvent) => {
          console.log("Deep Link branch Data:", event.referringParams);
        });

With your app opened and initialized just try Browser.open({url: "your branch url"}). The listener will never detect the new data.

Expected behavior

The addListener function should detect new data without the need of calling the function everytime you know new data will arrive. Otherwise the function (addListener) is missnamed and missleading.

SDK Version

7.0.0

Make and Model

Any android

OS

Android 13

Additional Information/Context

No response

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale due to inactivity for 60 days. If this issue is still relevant, please respond with any updates or this issue will be closed in 7 days. If you believe this is a mistake, please comment to let us know. Thank you for your contributions.

marshall86 commented 2 months ago

what's the status of this bug? Any updates?

metinjakupi commented 1 month ago

Bump

metinjakupi commented 1 month ago

@GiannisS did you find a solution?