BranchMetrics / capacitor-branch-deep-links

Capacitor plugin for branch.io deep links
MIT License
32 stars 43 forks source link

IOS Build not passing with version 5.0.0 of the plugin #67

Closed gabides closed 11 months ago

gabides commented 1 year ago

Describe the bug

when building the app on iOS

▸ Copying Plugin.h
▸ Copying CapacitorBranchDeepLinks-umbrella.h
▸ Processing CapacitorBranchDeepLinks-Info.plist

❌  /app-project/node_modules/capacitor-branch-deep-links/ios/Plugin/BranchService.swift:40:40: cannot find type 'BranchQRCode' in scope

    func getBranchQRCode(branchQRCode: BranchQRCode, buo: BranchUniversalObject, linkProperties: BranchLinkProperties, completion: @escaping (String?, Error?)->(Void)) -> Void {
                ^~~~~~~
❌  /app-project/node_modules/capacitor-branch-deep-links/ios/Plugin/BranchService.swift:46:28: cannot convert value of type '_' to expected argument type 'String?'

                completion(qrCodeString,nil)
                                       ^~~~~~~~~~~~
⚠️  /app-project/node_modules/capacitor-branch-deep-links/ios/Plugin/Plugin.swift:83:14: 'success()' is deprecated: renamed to 'resolve()'

        call.success()
                           ^
⚠️  /app-project/node_modules/capacitor-branch-deep-links/ios/Plugin/Plugin.swift:158:14: 'success()' is deprecated: renamed to 'resolve()'

        call.success()
             ^~~~~~~
❌  /app-project/node_modules/capacitor-branch-deep-links/ios/Plugin/Plugin.swift:253:22: cannot find 'BranchQRCode' in scope

        let qrCode = BranchQRCode()
             ^~~~~~~

❌  /app-project/node_modules/capacitor-branch-deep-links/ios/Plugin/Plugin.swift:272:39: cannot infer contextual base in reference to member 'JPEG'

                qrCode.imageFormat = .JPEG
                     ^~~~~~~~~~~~

❌  /app-project/node_modules/capacitor-branch-deep-links/ios/Plugin/Plugin.swift:274:39: cannot infer contextual base in reference to member 'PNG'

                qrCode.imageFormat = .PNG

Steps to reproduce

  1. Add capacitor-branch-deep-links version 5.0.0 to your capacitor app (capacitor v4)
  2. npx cap sync
  3. open xcode, build the app on a device or simulator

Expected behavior

you should be able to build an app with this plugin latest version on iOS and capacitor 4

SDK Version

5.0.0

Make and Model

any simulator or actual device

OS

ios

Additional Information/Context

No response

ctrengove commented 1 year ago

I believe this may be caused by the fact that the included version of the Podfile.lock file is out of date, which can then easily lead to the Branch pod not being updated to the version required by this plugin.

Sampath-Lokuge commented 1 year ago

@gabides Have you sorted out this issue now?

gdeluna-branch commented 11 months ago

Should be resolved as of latest https://www.npmjs.com/package/capacitor-branch-deep-links/v/6.0.0 https://github.com/BranchMetrics/capacitor-branch-deep-links/releases/tag/v6.0.0

You may need to pod repo update