search

BranchMetrics / cordova-ionic-phonegap-branch-deep-linking-attribution

The Branch Cordova Ionic Phonegap SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/apps/cordova-phonegap-ionic/
MIT License
233 stars 146 forks source link

shareSheet Facebook option appears to be broken #106

Closed GrahenKraken closed 8 years ago

GrahenKraken commented 8 years ago

I am using Cordova 6.1.1. on a Samsung Galaxy Grand Prime (SM-G531H) with Android 5.1.1. The plugin is the latest version (downloaded about an hour ago). I will test on a Nexus 5 soon to confirm if necessary.

ss

The facebook icon is broken, and choosing the option opens up a blank screen for a few seconds, then closes it with no callback called in JS.

Update: the issue is there only if there is no native Facebook app installed on the device.

renesansz commented 8 years ago

Hello @GrahenKraken , I cannot replicate the issue, not sure if this is the plugin's fault or not? This is what I've got and it works well:

Could you try it on different phones?

GrahenKraken commented 8 years ago

@renesansz do you have the Facebook application installed? I have the problem only when I don't have Facebook installed.

renesansz commented 8 years ago

This is how it looks like when there's no Facebook application installed.

GrahenKraken commented 8 years ago

Could it be because I have the facebook plugin (https://github.com/jeduan/cordova-plugin-facebook4) installed? I will do some more testing and report back, I'll try rebooting and checking if anything else makes the share-sheet "forget" about Facebook.

renesansz commented 8 years ago

cool, thanks! Please do try that solution, that might solve your problem. Because from my point of view, I think this issue is not caused by the plugin anymore.

renesansz commented 8 years ago

@GrahenKraken Let me know if this issue has been resolved.

Thanks

aaustin commented 8 years ago

Closing out unless otherwise noted.