search

BranchMetrics / cordova-ionic-phonegap-branch-deep-linking-attribution

The Branch Cordova Ionic Phonegap SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/apps/cordova-phonegap-ionic/
MIT License
234 stars 144 forks source link

4.0.0 build fails on ios #601

Closed deliverymanager closed 4 years ago

deliverymanager commented 5 years ago

Did you test on ios@5.0.1? The build fails.

The following build commands failed:
    CompileC /Users/adomvris/Library/Developer/Xcode/DerivedData/axnikanela-aecsgtpgwdmanqhalsfovkloyltn/Build/Intermediates.noindex/axnikanela.build/Release-iphonesimulator/axnikanela.build/Objects-normal/x86_64/BranchSDK.o /Users/adomvris/projects/buildmobileorderonmac/mobileorder2/axnikanela/mobileorder2/platforms/ios/axnikanela/Plugins/branch-cordova-sdk/BranchSDK.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)
xcodebuild: Command failed with exit code 65
keapick commented 5 years ago

It's in the release notes. Known issue with cordova and cocoapods. Workaround is to build from xcode.

https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/releases/tag/v4.0.0

Juanperezc commented 5 years ago

Same issue

echo-branch commented 5 years ago

Workaround is to build from Xcode.

Also to set expectations. This is a cordova bug, and we will not be investing time to workaround this issue anytime soon. It would require significant work on the native iOS SDK to fix.

Mapiac commented 4 years ago

@echo-branch can you tell us more about what you know and maybe someone can take it on?

echo-branch commented 4 years ago

@Mapiac Of course, the root problem is Cordova does not work with an XCode build option. The fix for this is for the Branch iOS SDK to be rearranged, but this has implications in other areas which will take some time to resolve.

A possible workaround is to modify your Cordova iOS to respect this option. One user reports this worked for them. https://github.com/apache/cordova-ios/issues/659

Also we finally have new maintainers for Cordova, so we should have an update soonish.

Mapiac commented 4 years ago

Thank you @echo-branch Btw is there a place the new maintainers are introduced? Or a blog post I missed?

echo-branch commented 4 years ago

This should be resolved in the latest release.

AleCat83 commented 4 years ago

This is still happening to me in version 4.2.1. I m able to go around this building with Xcode but this force me to remove the plugin when testing with ionic live reload,

tamsel12 commented 3 years ago

Yes, The Build is failed if i have updated the 4.2.1 version. So i am building with only xcode.