search

BranchMetrics / cordova-ionic-phonegap-branch-deep-linking-attribution

The Branch Cordova Ionic Phonegap SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/apps/cordova-phonegap-ionic/
MIT License
234 stars 144 forks source link

Cordova 10012020 465, 601, 604, 605 #613

Closed codinronan closed 4 years ago

codinronan commented 4 years ago

This is a bug fix update.

Update iOS SDK to 0.31.1 Update Android SDK to 4.2.1 Remove use_frameworks from Pod install Remove addition of entitlements files, use existing ones instead & delete JS scripts that were creating them

Known issues: iOS command line build seems to work provided ALL dependencies are updated and after use_frameworks was removed: node 10.15 cordova: 9.0.0 cordova-ios: 5.1.1 branch: 4.0.1 CocoaPods: 1.8.4

The test app in use demonstrating this version in action is here: https://github.com/engineerapart/branch-cordova-helloworld

It uses my own published npm package name but the code is identical to what is being submitted here.

Relevant tickets: https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/issues/465 https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/issues/610 (and the related PR https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/pull/575) https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/issues/606 https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/issues/605 https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/issues/604 https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/issues/601

codinronan commented 4 years ago

Checking on Ionic 4 is in progress. Give me a bit and I'll update that here as well.

Ionic 4 with Cordova is working fine: https://github.com/engineerapart/branch-ionic-cordova-helloworld

adrianyg7 commented 4 years ago

https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/issues/554#issuecomment-576490067

codinronan commented 4 years ago

Ionic 4 with Capacitor is also working: https://github.com/engineerapart/branch-ionic-capacitor-helloworld

echo-branch commented 4 years ago

Looks good. Going to merge to staging for further QA.