search

BranchMetrics / cordova-ionic-phonegap-branch-deep-linking-attribution

The Branch Cordova Ionic Phonegap SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/apps/cordova-phonegap-ionic/
MIT License
234 stars 144 forks source link

Getting a warning for 'compile' is obsolete #636

Open powysm opened 4 years ago

powysm commented 4 years ago

using release 3.4.0 in studio 3.3.2

I get the following message on build

WARNING: Configuration 'compile' is obsolete and has been replaced with 'implementation' and 'api'. It will be removed at the end of 2018.

This is the offending line:

compile (name:'Branch', ext:'aar')

Changing to the following resolves:

implementation (name:'Branch', ext:'aar')

echo-branch commented 4 years ago

That's a maintenance release for users who cannot upgrade. I believe the 4.x series has that change.

@codinronan

codinronan commented 4 years ago

@powysm @echo-branch That is correct; the 3.x releases are intended to be backwards compatible with older Android Studio + Older Xcode, meaning we aren't changing things like compile vs implementation and CocoaPods support.

The rules.gradle file was removed in the 4.x releases and uses the default Cordova config (which uses implementation) so it no longer has that error.

The 4.x releases are 100% up to date and don't have those warnings.