search

BranchMetrics / cordova-ionic-phonegap-branch-deep-linking-attribution

The Branch Cordova Ionic Phonegap SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/apps/cordova-phonegap-ionic/
MIT License
234 stars 144 forks source link

fix build ios project name #640

Open Leo1305Pineda opened 4 years ago

Leo1305Pineda commented 4 years ago

There is an error building the project in ios. the cause is that if in the config.xml the project name tag is placed like this. image the following error is generated image This is due to the characters new line \ n, return \ r and spaces before and after the project name. Partial solution: not use these characters in the name del projecto. Definitive solution with regular expressions: replace (/ [\ r \ n] + / gm, '') .replace (/ (^ [\ s] + | [\ s] + $) / g, '')

codinronan commented 4 years ago

Thanks @Leo1305Pineda this looks like a good change, we'll make sure it gets in.

echo-branch commented 4 years ago

@adrianyg7 Was this included in another PR?

adrianyg7 commented 4 years ago

@echo-branch no @Leo1305Pineda how did you get a config.xml file containing new-lines/return/spaces on name tag? Neither Cordova, PhoneGap or Ionic cli will produce such thing.

Leo1305Pineda commented 4 years ago

The framework does not generate the spaces, the return or the new line. This happens if the developer is the one who unintentionally causes them, will not allow compilation and the console does not provide more details about the reason for the problem.

El jue., 9 jul. 2020 a las 20:02, Adrián Márquez (notifications@github.com) escribió:

@echo-branch https://github.com/echo-branch no @Leo1305Pineda https://github.com/Leo1305Pineda how did you get a config.xml file containing new-lines/return/spaces on name tag? Neither Cordova, PhoneGap or Ionic cli will produce such thing.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking-attribution/pull/640#issuecomment-656408151, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBJQPYWDG4VHIBGONZWAJTR2ZLAZANCNFSM4LFAFOHA .