BranchMetrics / cordova-ionic-phonegap-branch-deep-linking-attribution

The Branch Cordova Ionic Phonegap SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/apps/cordova-phonegap-ionic/
MIT License
234 stars 145 forks source link

continueUserActivity override prevents other plugins to listen to Universal Links #674

Open AleCat83 opened 4 years ago

AleCat83 commented 4 years ago

Hello, In my Ionic (just migrate to) 5 project I need to handle both branch and regular Universal links. To do this I use Branch cordova plugin and https://github.com/ionic-team/ionic-plugin-deeplinks. Universal links were working fine until I added the Branch plugin. After some digging I think the problem is that both plugins override the continueUserActivity method, so what is happening is that Branch cordova plugin consume the universal link without it being propagated to the other plugin.

Is there a way to handle non branch Universal Links from Branch cordova plugin? If not why Branch override this method? Is it possible to simply remove the following code in AppDelegate+BranchSdk.m? `// Respond to Universal Links

Commenting it out works but I am not sure if doing this results in breaking something else.

Thank you

adrianyg7 commented 3 years ago

Hey @AleCat83 please note that ionic-plugin-deeplinks is marked as incompatible with branch-deep-linking https://help.branch.io/developers-hub/docs/cordova-phonegap-ionic#compiling-incompatibilities