search

BranchMetrics / cpp-branch-deep-linking-attribution

Branch Metrics Win32/C++ SDK
https://help.branch.io/developers-hub/docs/windows-cpp-sdk-overview
MIT License
10 stars 5 forks source link

The Poco dependency should be lowercased #114

Open dalamber opened 3 years ago

dalamber commented 3 years ago

Right now Branch depends on Poco/1.10.1@pocoproject/stable and links to CONAN_PKG::Poco. Also, there is a dependency on OpenSSL. Not sure where do you get this from, but the official Conan center repository only have lowercased poco and openssl: https://conan.io/center/poco, https://conan.io/center/openssl

dalamber commented 3 years ago

Probably, you were using the bincrafters repo (which is now deprecated). The "Poco" recipe is now also deprecated (see here and here's the "poco" package that is maintained.

My usage scenario: I have my own conan repo where I store my dependencies. I uploaded your conanfile to my own repo and used it without any problems for a while. But once I have removed the bincrafters repo (and a few others like conan-community) I no longer can compile Branch because there is no such "Poco". So I updated the recipe to depend on "poco", however, as I mentioned in my initial report, your CMakeLists.txt expects CONAN_PKG:Poco which I cannot easily change. Of course I can write a patch (or fork your project -- I actually did this for testing purposes), however, I ask you to make this change in your repo to be fully compatible with official conan repositories (i.e. depend on "poco", "openssl" -- not "Poco" and "OpenSSL".

Thanks, Anton

dalamber commented 3 years ago

Here's the working patch for 1.2.2 version: https://gist.github.com/dalamber/ce92ec070daee77350e0b1a71d9ab97c It works with having only official conan repository added to the remotes:

Antons-MPB:~ antons$ conan remote list
conancenter: https://center.conan.io [Verify SSL: True]
Antons-MPB:~ antons$
jdee commented 3 years ago

Thanks for the feedback. We'll adjust the next time we cut a release.