BranchMetrics / ios-branch-deep-linking-attribution

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://help.branch.io/developers-hub/docs/ios-sdk-overview
MIT License
728 stars 229 forks source link

Sdk 1954 - [iOS Automation] Move Qentelli Testbed app to iOS SDK #1255

Closed NidhiDixit09 closed 1 year ago

NidhiDixit09 commented 1 year ago

Reference

SDK-1954 - [iOS Automation] Move Qentelli Testbed app to iOS SDK https://branch.atlassian.net/browse/SDK-1954

Summary

Motivation

Align testing flow with Android SDK. In Android SDK testbed app is inside main repo. This makes compilation convenient. Pull request for which this change is done - https://github.com/BranchMetrics/qentelli-saas-sdk-testing-automation/pull/22

Type Of Change

Testing Instructions

Test with workflow "SaaS SDK Automation Tests" using the current branch. It should be able to run tests successfully on Browserstack.

Screenshot 2023-05-17 at 7 35 58 PM

cc @BranchMetrics/saas-sdk-devs for visibility.

gdeluna-branch commented 1 year ago

Verified the test results and it reflects the latest security updates. ✅

AlejandrosTesla8 commented 1 year ago

On Wed, May 17, 2023 at 10:41 PM ndixit-branch @.***> wrote:

Reference

SDK-1954 - [iOS Automation] Move Qentelli Testbed app to iOS SDK https://branch.atlassian.net/browse/SDK-1954 Summary

  • Copied Qentelli TestBed app from repo BranchMetrics/qentelli-saas-sdk-testing-ios-testbed ( https://github.com/BranchMetrics/qentelli-saas-sdk-testing-ios-testbed)
  • Updated Github Action automation-trigger-test.yml to
    • Compile local app - DeeplinkDemo
    • Added command to upload DeeplinkDemo to Browserstack and set returned app_url as environment variable.
    • Some restructuring done in workflow - converted jobs into steps. Removed extra steps which are not required anymore because of above changes.

Motivation

Align testing flow with Android SDK. In Android SDK testbed app is inside main repo. This makes compilation convenient. Pull request for which this change is done - BranchMetrics/qentelli-saas-sdk-testing-automation#22 https://github.com/BranchMetrics/qentelli-saas-sdk-testing-automation/pull/22 Type Of Change

  • New feature (non-breaking change which adds functionality)

Testing Instructions

Test with workflow "SaaS SDK Automation Tests" using the current branch. It should be able to run tests successfully on Browserstack. [image: Screenshot 2023-05-17 at 7 35 58 PM] https://user-images.githubusercontent.com/93544270/239121204-7f9801b4-c42c-40ac-be24-a87ebf7269f0.png

cc @BranchMetrics/saas-sdk-devs https://github.com/orgs/BranchMetrics/teams/saas-sdk-devs for visibility.

You can view, comment on, or merge this pull request online at:

https://github.com/BranchMetrics/ios-branch-deep-linking-attribution/pull/1255 Commit Summary

File Changes

(68 files https://github.com/BranchMetrics/ios-branch-deep-linking-attribution/pull/1255/files )

Patch Links:

- https://github.com/BranchMetrics/ios-branch-deep-linking-attribution/pull/1255.patch

https://github.com/BranchMetrics/ios-branch-deep-linking-attribution/pull/1255.diff

— Reply to this email directly, view it on GitHub https://github.com/BranchMetrics/ios-branch-deep-linking-attribution/pull/1255, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7TCZN7NNAW5DUCO7U46NTLXGWD5XANCNFSM6AAAAAAYF4F2MU . You are receiving this because you are subscribed to this thread.Message ID: @.*** com>

--  WWDC22

NidhiDixit09 commented 1 year ago

@gdeluna-branch I have updated GHA to remove reference to branch 'gdeluna-branch/RemoveLoggingAppUrl' as its already merged into master. Please review it.