BranchMetrics / ios-branch-deep-linking-attribution

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://help.branch.io/developers-hub/docs/ios-sdk-overview
MIT License
728 stars 229 forks source link

Breaking Change moving from 2.1.2 to 2.2.0 #1265

Closed farmer-dhi closed 1 year ago

farmer-dhi commented 1 year ago

Describe the bug

Version 2.1.2 has the method delayInitToCheckForSearchAds() which was removed in 2.2.0. This has broken my build, and it's not clear what I should replace it with (if anything).

Steps to reproduce

  1. Create a new project and install Branch v2.1.2
  2. use the method delayInitToCheckForSearchAds()
  3. Update to Branch v2.2.0
  4. Attempt to build project

EXPECTED: Build succeeds ACTUAL: Build fails

Expected behavior

I expected a non-major version change to allow my project to build without needing changes from me.

SDK Version

2.2.0

XCode Version

14.3

Device

Simulator

OS

16.4

Additional Information/Context

No response

jf-branch commented 1 year ago

Hi @farmer-dhi, the Apple API that delay check was used for has been deprecated and therefore the delay is no longer needed. You can remove that line of code.

farmer-dhi commented 1 year ago

Thank you, I will do so :)

sfoulston commented 1 year ago

Just found this as well - it would be great if the explanation / migration notes for breaking changes like this could be documented in the release notes 🙏