BranchMetrics / ios-branch-deep-linking-attribution

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://help.branch.io/developers-hub/docs/ios-sdk-overview
MIT License
728 stars 229 forks source link

[SDK-2055] Remove v1/event code #1279

Closed nsingh-branch closed 1 year ago

nsingh-branch commented 1 year ago

Reference

SDK-2055 -- Remove v1/event code

Summary

Removed existing code for deprecated, no-op v1/events (sendCommerceEvent and userCompletedAction). This required deleting the files and all references of BNCCommerceEvent and BranchUserCompletedActionRequest. Since BNCProductCategory and BNCCurrency were located in BNCCommerceEvent, they were moved to their own new respective files.

Motivation

Remove old code that has been deprecated for a sufficient amount of time.

Type Of Change

Testing Instructions

Integrate the SDK, run the app, and run the tests to ensure everything is still functioning correctly.

cc @BranchMetrics/saas-sdk-devs for visibility.

codecov[bot] commented 1 year ago

Codecov Report

Merging #1279 (174c8ec) into master (731e879) will increase coverage by 0.35%. Report is 48 commits behind head on master. The diff coverage is 40.81%.

@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
+ Coverage   51.42%   51.78%   +0.35%     
==========================================
  Files          76       76              
  Lines       10947    10766     -181     
  Branches     4238     4164      -74     
==========================================
- Hits         5630     5575      -55     
+ Misses       5060     4942     -118     
+ Partials      257      249       -8     
Files Changed Coverage Δ
BranchSDK/BNCCurrency.m 0.00% <ø> (ø)
BranchSDK/BNCProductCategory.m 0.00% <0.00%> (ø)
BranchSDK/BNCServerRequestQueue.m 86.46% <ø> (-0.09%) :arrow_down:
BranchSDK/Branch.m 39.53% <ø> (+0.53%) :arrow_up:
BranchSDK/BranchUniversalObject.m 60.63% <ø> (-0.76%) :arrow_down:
BranchSDK/BNCReferringURLUtility.m 95.79% <83.33%> (-1.59%) :arrow_down:

... and 2 files with indirect coverage changes

echo-branch commented 1 year ago

The framework build needs to be updated in BranchSDK.xcodeproj. Otherwise it'll fail when building xcframeworks.

nsingh-branch commented 1 year ago

The framework build needs to be updated in BranchSDK.xcodeproj. Otherwise it'll fail when building xcframeworks.

Pushed some updates and the checks are passing now so it appears to be fixed.