Closed NidhiDixit09 closed 1 year ago
Merging #1288 (da55b9e) into master (e760484) will increase coverage by
0.47%
. Report is 206 commits behind head on master. The diff coverage is76.00%
.
@@ Coverage Diff @@
## master #1288 +/- ##
==========================================
+ Coverage 51.26% 51.73% +0.47%
==========================================
Files 78 74 -4
Lines 11156 10663 -493
Branches 4316 4121 -195
==========================================
- Hits 5719 5517 -202
+ Misses 5174 4894 -280
+ Partials 263 252 -11
Files Changed | Coverage Δ | |
---|---|---|
BranchSDK/BranchInstallRequest.m | 67.18% <ø> (ø) |
|
BranchSDK/BranchOpenRequest.m | 61.79% <21.42%> (-1.35%) |
:arrow_down: |
BranchSDK/Branch.m | 40.16% <59.09%> (+2.07%) |
:arrow_up: |
BranchSDK/BranchEvent.m | 62.27% <69.23%> (-0.84%) |
:arrow_down: |
Branch-TestBed/Branch-TestBed/AppDelegate.m | 44.35% <100.00%> (+1.68%) |
:arrow_up: |
BranchSDK/BNCPreferenceHelper.m | 79.97% <100.00%> (+0.19%) |
:arrow_up: |
BranchSDK/BNCSKAdNetwork.m | 82.81% <100.00%> (+0.55%) |
:arrow_up: |
BranchSDK/BNCServerInterface.m | 66.82% <100.00%> (+0.39%) |
:arrow_up: |
BranchSDK/BranchPluginSupport.m | 83.33% <100.00%> (ø) |
Reference
SDK-1982 -- [iOS] SKAN Simplification DB updates . https://branch.atlassian.net/browse/SDK-1982
Summary
Motivation
Support SKAN 4.0 DB Simplication.
Type Of Change
Testing Instructions
With Every INSTALL/OPEN/EVENT requests, Verify using logs SDK is sending current SKAN window number. Verify in response , SDK is getting back conversion values. Some of the samples are here - https://www.notion.so/brancheng/SDK-SKAN-Testing-Results-5a74041cd815457292725673097f66c4
cc @BranchMetrics/saas-sdk-devs for visibility.