search

BranchMetrics / ios-branch-deep-linking-attribution

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://help.branch.io/developers-hub/docs/ios-sdk-overview
MIT License
728 stars 229 forks source link

SDK-1711 fix crash on iOS 12 when using the pre-built xcframework #1325

Closed echo-branch closed 11 months ago

echo-branch commented 11 months ago

Reference

SDK-1711 fix crash on iOS 12 when using the pre-built xcframework

Summary

Copies fix for linker issue from the Xamarin hotfix

Motivation

Xamarin uses the binary framework and is severely impacted by this crash.

Type Of Change

Testing Instructions

Integrate a test app using the pre-built xcframework Run app on iOS 12, notice crash.

When using the version built with this change, the app should not crash.

cc @BranchMetrics/saas-sdk-devs for visibility.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b7ab30a) 53.77% compared to head (b955e8c) 53.77%. Report is 6 commits behind head on master.

Files Patch % Lines
BranchSDK/Branch.m 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1325 +/- ## ========================================== - Coverage 53.77% 53.77% -0.01% ========================================== Files 68 68 Lines 10086 10087 +1 Branches 3886 3886 ========================================== Hits 5424 5424 - Misses 4409 4410 +1 Partials 253 253 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.