(WIP) - SDK 2223 DMA Consent Params Implementation

BranchMetrics / ios-branch-deep-linking-attribution

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.

MIT License

728 stars 229 forks source link

Reference

SDK-2223 -- Design and implement key/values to represent consent param

Summary

Added following API in Branch Class. + (void) setDMAParamsForEEA:(BOOL) eeaRegion AdPersonalizationConsent:(BOOL) adPersonalizationConsent AdUserDataUsageConsent:(BOOL) adUserDataUsageConsent;
Branch SDK will save DMA Compliance Parameters, set by developer using above API, and will send to server with install, open and event requests. BranchPreferenceHelper class is updated to store and read these params.
Added unit test for testing above API

Motivation

Support new params added in Google Conversion API for DMA Compliance.

Type Of Change

[ ] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Testing Instructions

All unit tests should pass.
Call API setDMAParamsForEEA and check -- SDK is sending value of eeaRegion, with every /v1/install , /v1/open, /v2/event , v1/pageview request. -- SDKis sending value of adPersonalizationConsent / adUserDataUsageConsent with every /v1/install , /v1/open, /v2/event , v1/pageview request only if -
- eeaRegion is true OR
- eeaRegion is false and adPersonalizationConsent / adUserDataUsageConsent is also set to false Ref : https://www.notion.so/brancheng/Google-DMA-Compliance-c19ed28d2ea74b2b9fa4d2d77f8cdcbe

cc @BranchMetrics/saas-sdk-devs for visibility.

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (bf6e9ee) 50.73% compared to head (6a61813) 50.98%. Report is 2 commits behind head on master.

:exclamation: Current head 6a61813 differs from pull request most recent head ecb5e3b. Consider uploading reports for the commit ecb5e3b to get more accurate results

Files	Patch %	Lines
BranchSDK/BNCPreferenceHelper.m	86.95%	0 Missing and 6 partials :warning:

Files

Patch %

Lines

BranchSDK/BNCPreferenceHelper.m

86.95%

0 Missing and 6 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1345 +/- ## ========================================== + Coverage 50.73% 50.98% +0.24% ========================================== Files 68 68 Lines 10081 10144 +63 Branches 3864 3884 +20 ========================================== + Hits 5115 5172 +57 Misses 4708 4708 - Partials 258 264 +6 ```

BranchMetrics / ios-branch-deep-linking-attribution