search

BranchMetrics / ios-branch-deep-linking-attribution

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://help.branch.io/developers-hub/docs/ios-sdk-overview
MIT License
728 stars 229 forks source link

run unit tests against master branch so we have something to compare PR's to #1363

Open cameroncooks-branch opened 8 months ago

cameroncooks-branch commented 8 months ago

Reference

SDK-XXXX -- .</p> <h2>Summary</h2> <!-- Simple summary of what was changed. --> <h2>Motivation</h2> <!-- Why are you making this change? If it's for fixing a bug, if possible, please include a code snippet or example project that demonstrates the issue. --> <h2>Type Of Change</h2> <!-- Please delete options that are not relevant --> <ul> <li>[ ] Bug fix (non-breaking change which fixes an issue)</li> <li>[ ] New feature (non-breaking change which adds functionality)</li> <li>[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)</li> <li>[ ] This change requires a documentation update</li> </ul> <h2>Testing Instructions</h2> <!-- Testing instructions, example code snippets, etc --> <!-- Checklist --> <!-- My code follows the style guidelines of this project --> <!-- I have performed a self-review of my code --> <!-- I have commented my code, particularly in hard-to-understand areas --> <!-- I have made corresponding changes to the documentation --> <!-- I have added tests that prove my fix is effective or that my feature works --> <!-- New and existing unit tests pass locally with my changes --> <p>cc @BranchMetrics/saas-sdk-devs for visibility.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codecov[bot]"><img src="https://avatars.githubusercontent.com/in/254?v=4" />codecov[bot]</a> commented <strong> 8 months ago</strong> </div> <div class="markdown-body"> <h2><a href="https://app.codecov.io/gh/BranchMetrics/ios-branch-deep-linking-attribution/pull/1363?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BranchMetrics">Codecov</a> Report</h2> <p>All modified and coverable lines are covered by tests :white_check_mark:</p> <blockquote> <p>Project coverage is 51.51%. Comparing base <a href="https://app.codecov.io/gh/BranchMetrics/ios-branch-deep-linking-attribution/commit/1b03a815400e49e7adc89e7f51bbc4628e6601ec?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BranchMetrics">(<code>1b03a81</code>)</a> to head <a href="https://app.codecov.io/gh/BranchMetrics/ios-branch-deep-linking-attribution/commit/0d03cc1c4e1651e87bf7cd233121eeaab8e8e711?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BranchMetrics">(<code>0d03cc1</code>)</a>. Report is 74 commits behind head on master.</p> </blockquote> <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #1363 +/- ## ========================================== + Coverage 51.27% 51.51% +0.23% ========================================== Files 66 66 Lines 10092 10092 Branches 3697 3701 +4 ========================================== + Hits 5175 5199 +24 + Misses 4654 4626 -28 - Partials 263 267 +4 ``` </details> <p><a href="https://app.codecov.io/gh/BranchMetrics/ios-branch-deep-linking-attribution/pull/1363?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BranchMetrics">:umbrella: View full report in Codecov by Sentry</a>.<br /> :loudspeaker: Have feedback on the report? <a href="https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BranchMetrics">Share it here</a>.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ahmednawar"><img src="https://avatars.githubusercontent.com/u/16910208?v=4" />ahmednawar</a> commented <strong> 5 months ago</strong> </div> <div class="markdown-body"> <p>@cameroncooks-branch is this still needed? should it be merged?</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>