search

BranchMetrics / ios-branch-deep-linking-attribution

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://help.branch.io/developers-hub/docs/ios-sdk-overview
MIT License
731 stars 228 forks source link

Add safety fallback when we are unable to unarchive requests #1368

Closed echo-branch closed 5 months ago

echo-branch commented 5 months ago

Reference

SDK-2263

Summary

On failure to unarchive our request queue, we do not remove the incorrect requests. This leads to repeated failures to unarchive.

Believe this issue can occur when upgrading to version 3.3 from some older versions.

Motivation

Safer fallback when we fail to unarchive.

Type Of Change

Testing Instructions

We do not have internal repro. However we can mimic a failure to unarchive, will demonstrate during team working meeting.

cc @BranchMetrics/saas-sdk-devs for visibility.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 96.55172% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 51.18%. Comparing base (4152af5) to head (104c760). Report is 3 commits behind head on master.

Files Patch % Lines
Sources/BranchSDK/BranchOpenRequest.m 92.30% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1368 +/- ## ========================================== + Coverage 51.03% 51.18% +0.15% ========================================== Files 66 66 Lines 10126 10151 +25 Branches 3714 3728 +14 ========================================== + Hits 5168 5196 +28 + Misses 4700 4695 -5 - Partials 258 260 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.