SDK 2228 DMA Test automation

BranchMetrics / ios-branch-deep-linking-attribution

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.

https://help.branch.io/developers-hub/docs/ios-sdk-overview

MIT License

731 stars 228 forks source link

SDK 2228 DMA Test automation #1377

Closed NidhiDixit09 closed 3 months ago

NidhiDixit09 commented 5 months ago

Reference

SDK-2228 -- DMA Compliance testing automation https://branch.atlassian.net/browse/SDK-2228

Summary

Added buttons in Test Bed App -
- Set DMA Params - It calls Branch.setDMAParamsForEEA API
- Send V2 Event - It calls BranchEvent.standardEvent API
Updated logging Function and moved initialization code to Button click events.
Changed linking method to cocoapods from static lib. Note : Ref is added to branch 'SDK-2228-iOS-DMA-Compliance-Automation' in workflow for testing purpose only. It will be reverted back before merging into master branch.

Type Of Change

[ ] New feature (non-breaking change which adds functionality)

Testing Instructions

Run workflow from this branch manually and verify in logs( or Browserstack) that Set DMA Params test passed.

cc @BranchMetrics/saas-sdk-devs for visibility.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 51.06%. Comparing base (1836823) to head (ec875ad). Report is 9 commits behind head on master.

:exclamation: Current head ec875ad differs from pull request most recent head 5b8a903

Please upload reports for the commit 5b8a903 to get more accurate results.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1377 +/- ## ========================================== - Coverage 51.10% 51.06% -0.04% ========================================== Files 66 66 Lines 10158 10126 -32 Branches 3724 3712 -12 ========================================== - Hits 5191 5171 -20 + Misses 4707 4701 -6 + Partials 260 254 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

echo-branch commented 4 months ago

@NidhiDixit09 Just took a closer look at this test app and I'm gonna make a follow up ticket to modernize it. It's got some odd existing design choices.

ahmednawar commented 3 months ago

@NidhiDixit09 what's next for this PR?

NidhiDixit09 commented 3 months ago

@nsingh-branch Can you re-approve this pull request. I have pushed fixes for review comments and updated ref branch.