BranchMetrics / ios-branch-deep-linking-attribution

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://help.branch.io/developers-hub/docs/ios-sdk-overview
MIT License
731 stars 228 forks source link

Crash [BNCReferringURLUtility parseReferringURL] #1411

Open LukeDurrant opened 1 month ago

LukeDurrant commented 1 month ago

Describe the bug

Crashes if you open the app clip via TestFlight.

Fatal Exception: NSInvalidArgumentException 0 CoreFoundation 0x83f20 exceptionPreprocess 1 libobjc.A.dylib 0x16018 objc_exception_throw 2 Foundation 0x135e08 -[NSConcreteURLComponents initWithURL:resolvingAgainstBaseURL:] 3 Foundation 0x135cd4 +[NSURLComponents componentsWithURL:resolvingAgainstBaseURL:] 4 Clip 0x5ef034 -[BNCReferringURLUtility parseReferringURL:] + 49 (BNCReferringURLUtility.m:49) 5 Clip 0x600b64 -[Branch handleDeepLink:sceneIdentifier:] + 681 (Branch.m:681) 6 Clip 0x6013c8 -[Branch continueUserActivity:sceneIdentifier:] + 783 (Branch.m:783) 7 Clip 0x166690 DeepLinkProvider.continueWith(userActivity:) + 26 (DeepLinkProvider.swift:26) 8 Clip 0x5fd38 AppDelegate.application(:continue:restorationHandler:) + 84 (AppDelegate.swift:84) 9 Clip 0x5fdcc @objc AppDelegate.application(:continue:restorationHandler:) () 10 UIKitCore 0xebfcc8 -[UIApplication activityContinuationManager:continueUserActivity:]

Steps to reproduce

1. 2. 3.

Expected behavior

Don't crash

SDK Version

3.4.4

XCode Version

15.2

Device

iPhone 13 Pro

OS

17

Additional Information/Context

No response