search

BranchMetrics / ios-branch-deep-linking-attribution

The Branch iOS SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://help.branch.io/developers-hub/docs/ios-sdk-overview
MIT License
728 stars 228 forks source link

Branch modifying data inside deep link when +match_guaranteed is FALSE #1428

Open arthurgiani opened 2 months ago

arthurgiani commented 2 months ago

Describe the bug

This issue was originally posted on the Branch Flutter Plugin Repository.

When listening to the deep link, if deepLink[+match_guaranteed] is false, branch deep link is modifying data inside.

Steps to reproduce

The following flow is being made:

1) A deep link is created through the Branch API. 2) Through the API, I added a key-pair 'params' attribute containing some important info for my business rule on this link. 3) This link is sent to a random user (that does not have the app installed). 4) The user clicks on the link and download the app. 5) The app listens to the deep link.

Now, imagine that this 'params' attribute that I described on 2) contains an integer as one of the values. In this scenario, when +match_guaranteed=false, this attribute is being sent through FlutterBranchSdk.listSession() as a DOUBLE, not an int.

Screenshots Screenshot 1: event response when +match_guaranteed is FALSE (when app opens for the first time after the install) On the deep link creation, eventId is 0 (int), and not 0.0 (double) 366225160-5164a049-75ab-4039-905c-086028bf19ad

Screenshot 2: event response when +match_guaranteed is TRUE (when I click on the deep link with the app installed) On the deep link creation, eventId is 0 (int), exactly the way I settled on the backend. 366225765-b959aa4c-c648-4b4f-9d9b-c38be49449aa

Expected behavior

Expected behavior Branch link should always show exactly the same information as when they are created.

SDK Version

3.6.0

XCode Version

15.4

Device

Iphone 15 Pro Max

OS

17.4

Additional Information/Context

No response

github-actions[bot] commented 3 days ago

This issue has been automatically marked as stale due to inactivity for 60 days. If this issue is still relevant, please respond with any updates or this issue will be closed in 7 days. If you believe this is a mistake, please comment to let us know. Thank you for your contributions.