BranchMetrics / ios-branch-sdk-spm

Branch iOS SDK Swift Package Manager distribution
https://help.branch.io/developers-hub/docs/ios-basic-integration#via-swift-package-manager
MIT License
15 stars 10 forks source link

Umbrella header missing internal headers #14

Closed casperriboe closed 1 year ago

casperriboe commented 1 year ago

The issue with the missing headers is still not resolved and pops up from time to time.

The reason this is happening is because Package.swift indicates that the headers to be exposed is inside . of the path argument for Branch's target. This means all headers including the umbrella header which now raises the conflict since those listed in the warnings are not in the umbrella header. Xcode expects to use the umbrella header when it is present but now both an umbrella header exists along with all the separate headers.

The solution is to either:

  1. Include the missing headers in the umbrella header Branch.h and point directly to that header file from the package manifest, or
  2. Move all headers to a separate folder (could be include) and reference the folder from the manifest instead of using the root .
image

Here is an example of how this can be resolved: https://github.com/PureLayout/PureLayout/issues/256

echo-branch commented 1 year ago

@casperriboe Are you seeing this issue with 2.0.0+? The umbrella header has changed to be BranchSDK.h to avoid this issue.

casperriboe commented 1 year ago

We will check soon and I will let you know. Thanks!

echo-branch commented 1 year ago

No activity.