BranchMetrics / ios-branch-sdk-spm

Branch iOS SDK Swift Package Manager distribution
https://help.branch.io/developers-hub/docs/ios-basic-integration#via-swift-package-manager
MIT License
15 stars 10 forks source link

SDK-2206 patch for spm tuist #23

Closed echo-branch closed 6 months ago

echo-branch commented 6 months ago

Reference

SDK-2206 minimal patch for tuist SPM

Summary

tuist SPM is unable to locate the headers when using the external option, it only works with the package option. This change should fix this.

Motivation

unblock client that requires the external option

Type Of Change

Note this is non-breaking for SPM users.

Testing Instructions

See tuist notion page for details

cc @BranchMetrics/saas-sdk-devs for visibility.

echo-branch commented 6 months ago

@nsingh-branch Moving just the BranchSDK.h and the minor edit to the Package.swift didn't work out. Seems a combination of tuist and spm caching was masking that it only worked for the external option. This is in line with your testing. I updated the notion to include more details on making sure all caches are cleared in between tests.

In the end, I had to migrate to a more typical Swift Package Manager layout. Let's sync up tomorrow about testing this as the layout changes breaks test automation.