search

BranchMetrics / ios-branch-sdk-spm

Branch iOS SDK Swift Package Manager distribution
https://help.branch.io/developers-hub/docs/ios-basic-integration#via-swift-package-manager
MIT License
19 stars 11 forks source link

Crash #36

Open LukeDurrant opened 2 months ago

LukeDurrant commented 2 months ago

Describe the bug

Describe the bug

Screenshot 2024-06-26 at 9 13 36 am

Steps to reproduce

  1. Open app clip from test flight
  2. App doesn't launch and crashes

Expected behavior

Don't crash. Open app clip

SDK Version

3.4.4

XCode Version

15.2

Device

iPhone 13 Pro

OS

17

Additional Information/Context

No response

Steps to reproduce

  1. Open app clip from test flight
  2. App doesn't launch and crashes

I believe the SDK is expecting a URL but isn't getting one.

Expected behavior

Don't crash. Open app clip

SDK Version

3.4.4

XCode Version

15

Device

All

OS

All

Additional Information/Context

No response

amosaxe commented 1 month ago

@LukeDurrant were u able to solve this or hear back from branch team?

LukeDurrant commented 1 month ago

No didn’t. We’re migrating off branch instead. You can check for the referralUrl in the activity and simply don’t open branch if it doesn’t contain one. But it could lead to issues!

amosaxe commented 3 weeks ago

Sure, thanks for the revert. Can i know where are you migrating to?

LukeDurrant commented 3 weeks ago

implementing universal links so no SASS provider