search

BranchMetrics / sdk-release

TUNE iOS, Android, and Windows native SDKs
https://developers.tune.com/sdk/quick-starts/
GNU General Public License v3.0
56 stars 46 forks source link

SDK iOS 4.14.1 : func application(_ application: UIApplication, open url: URL, sourceApplication: String?, annotation: Any) #41

Open charliefancelli opened 6 years ago

charliefancelli commented 6 years ago

Hi,

In you SDK, the function Tune.handleOpen(url, sourceApplication: sourceApplication) need a URL and a String! but with SWIFT 3.2, the sourceApplication is now optional.

Can we do that to avoid crashes ?


func application(_ application: UIApplication, open url: URL, sourceApplication: String?, annotation: Any) -> Bool {

    // When the app is opened due to a deep link, call the Tune deep link setter
    if let s = sourceApplication {
      Tune.handleOpen(url, sourceApplication: s)
    }
    else{
      Tune.handleOpen(url, sourceApplication: nil)
    }
...
}

Regards,