search

BranchMetrics / unity-branch-deep-linking-attribution

The Branch Unity SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/apps/unity/
MIT License
118 stars 25 forks source link

Upgrade to Unity 2018 causing 3x Branch compile errors #131

Closed radbargames closed 6 years ago

radbargames commented 6 years ago

BUG: After upgrading to Unity 2018 the Branch SDK gives compile errors:

Assets/Branch/Editor/BranchPostProcessBuild.cs(153,13): error CS1061: Type UnityEditor.iOS.Xcode.PBXProject' does not contain a definition forHasFramework' and no extension method HasFramework' of typeUnityEditor.iOS.Xcode.PBXProject' could be found. Are you missing an assembly reference?

To reproduce:

  1. Install Unity 2018.1.f4
  2. Create a brand-new project
  3. Install the current Branch SDK
  4. Open Build Settings, select iOS and Switch Platform

Result: 4 compile errors as above, which were not present in Unity 2017

Looks like you may just need a UNITY_2017 || UNITY_2018 instead of just UNITY_2017?

antonargunov commented 6 years ago

@radbargames , change please row 133 in BranchPostProcessBuild.cs: change UNITY_2017 to UNITY_2017_1_OR_NEWER

dgoodine commented 6 years ago

This worked for me when I had the same problem installing today.