search

BranchMetrics / unity-branch-deep-linking-attribution

The Branch Unity SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/apps/unity/
MIT License
118 stars 25 forks source link

iOS native plugin extern function name conflict #211

Closed AFB-MORA closed 7 months ago

AFB-MORA commented 12 months ago

Describe the bug

Native plugin extern function name "_logout()" conflict with other plugin's (OneSignal) function name "_logout()". General function names like "_logout()" should not be used. You can rename general names with "branch" prefix like Facebook's "IOSFBLogOut();" function.

This issue is not specific to OneSingal. If I write my own custom plugin with "_logout()" or "_setIdentity(string)" functions, I can still see same error. These names are too general and cannot be used.

Steps to reproduce

  1. Add OneSignal
  2. Add Branch.io
  3. Build iOS project
  4. Archive Xcode project
  5. You see duplicate symbols error

Expected behavior

Build Xcode project successfully.

SDK Version

1.0.0

Unity Version

2022.3.10

Make and Model

Xcode

OS

iOS 17

Additional Information/Context

No response

echo-branch commented 11 months ago

@AFB-MORA Good catch, really surprised this issue hasn't been reported earlier. I'll add an internal ticket to handle this.

github-actions[bot] commented 9 months ago

This issue has been automatically marked as stale due to inactivity for 60 days. If this issue is still relevant, please respond with any updates or this issue will be closed in 7 days. If you believe this is a mistake, please comment to let us know. Thank you for your contributions.

echo-branch commented 9 months ago

This is still planned work, just taking longer to get resources devoted to a Unity update.

github-actions[bot] commented 7 months ago

This issue has been automatically marked as stale due to inactivity for 60 days. If this issue is still relevant, please respond with any updates or this issue will be closed in 7 days. If you believe this is a mistake, please comment to let us know. Thank you for your contributions.

github-actions[bot] commented 7 months ago

This issue has been closed due to inactivity. If this issue is still relevant, please reopen it or create a new one. Thank you for your contributions.