search

BranchMetrics / unity-branch-deep-linking-attribution

The Branch Unity SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/apps/unity/
MIT License
118 stars 25 forks source link

MiniJSON in the Branch SDK creates a namespace conflict with other SDKs using MiniJSON #69

Closed dwestgate closed 7 years ago

dwestgate commented 7 years ago

This is a partner-submitted request from Integrations Engineering:

In the Unity SDK, you're using MiniJSON. Unsurprising, as it's the de facto JSON parser for Unity. However, there are multiple versions of this floating round, everyone includes it in their SDK. Quite often the multiple versions collide with Other People's Plugins. One example, UniBill - one of the most prevalent In App Purchase plugins in use.

A super-easy fix is to rename the MiniJSON namespace to Branch_MiniJSON (or similar), fixup the references in BranchUniversalObject.cs, BranchLinkProperties.cs, and Branch.cs (and possibly some stuff in your demo dir).

antonargunov commented 7 years ago

Hello @dwestgate , thanks for report. We fixed that issue in new version of Unity SDK. New version is available for downloading.