BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
287 stars 101 forks source link

perf(core): fix object shorthand issue with minification #1002

Closed JagadeeshKaricherla-branch closed 4 months ago

JagadeeshKaricherla-branch commented 4 months ago

fix object shorthand issue with minification

Description

Fix issue with object shorthand not properly minified by Google closure compiler

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

github-actions[bot] commented 4 months ago

Test Results

  1 files  ±0    1 suites  ±0   54s :stopwatch: +4s 158 tests ±0  151 :white_check_mark: ±0  7 :zzz: ±0  0 :x: ±0  161 runs  ±0  154 :white_check_mark: ±0  7 :zzz: ±0  0 :x: ±0 

Results for commit 12a06437. ± Comparison against base commit 1b095f89.