search

BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
288 stars 101 forks source link

[INTENG-10570] Updated STANDARD Events #736

Closed msiddiq-branch closed 4 years ago

msiddiq-branch commented 4 years ago

Updated these below events under BRANCH_STANDARD_EVENTS as these were tagged as standard but branch Web SDK would fire these events as the custom event leading to 400 error.

https://branch.atlassian.net/browse/INTENG-10570

code-crusher commented 4 years ago

Thanks, @msiddiq-branch were you able to make v1/event calls with the new events to validate?

jdee commented 4 years ago

I guess these are v2 events after all: https://help.branch.io/developers-hub/docs/tracking-commerce-content-lifecycle-and-custom-events, so we should go with this change. Thanks @msiddiq-branch!

code-crusher commented 4 years ago

👍

jdee commented 4 years ago

PS - I added this page to test v2 events: https://github.com/BranchMetrics/web-branch-deep-linking-attribution/blob/master/event-v2-example.html. I was thinking to add a pulldown to select all valid standard events, but that variable is kind of hidden. We could maybe expose it. Anyway, for now this should be a convenient way to test.