BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
288 stars 101 forks source link

[minor] - INTENG-9671 - Journeys Additional Margin Getting Added for Single Page App #739

Closed jwangler-branch closed 4 years ago

jwangler-branch commented 4 years ago

What's done?

Why?

If you display a journey the body.style.marginTop or maringBottom will be calculated. If the closing animation and the journey display function are running at the same time, it generates a kind of offset to that margins.

image

That only happens if the host application executes window.branch.closeJourney(callback); and does a route change at the same time.

For more details feel free to have a look a the Jira or ask me any time.