BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
288 stars 101 forks source link

SDK-1587 : fix cdn example not loading #816

Closed JagadeeshKaricherla-branch closed 2 years ago

JagadeeshKaricherla-branch commented 2 years ago

Description

Web sdk example on the cdn at “https://cdn.branch.io/example.html” is failing to load the web sdk. It's missing part of the initialization code. Root cause : Variable COMPILER no longer exists in the make file and needs to be replaced by CLOSURE_COMPILER Workflow :

Fixes # (issue) : https://branch.atlassian.net/browse/SDK-1587

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Ran make script with release option and verified the generated example.html, verified linting, unit tests, integration tests have no regressions.

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js. 165kb 165kb
dist/build.min.js 78kb 78kb

Checklist:

Mentions:

List the person or team responsible for reviewing proposed changes.