BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
287 stars 101 forks source link

[patch] INTENG-17048 change the OG tags set logic for link data. #832

Closed hana-branch closed 1 year ago

hana-branch commented 1 year ago

Pull Request Template

Description

Change not to set the OG keys (eg: $og_title, $og_description, $og_image_url, $og_video, $og_type) that are gotten from <meta> tags in the webpage as the link data when there are $og_redirect, $desktop_url, or $fallback_url So we can scrap the OG tag from the webpage from $og_redirect, $desktop_url, or $fallback_url

Fixes # https://branch.atlassian.net/browse/INTENG-17048

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js. 164 KB 74 KB
dist/build.min.js 164 KB 74 KB

Mentions:

List the person or team responsible for reviewing proposed changes.

hana-branch commented 1 year ago

@JagadeeshKaricherla-branch To confirm, I just need to squash and merge this change once I get the approval? Thanks

JagadeeshKaricherla-branch commented 1 year ago

@hana-branch Yes just Squash and merge to master. We will merge to production after the nightly test runs pass.