BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
287 stars 100 forks source link

Move Google Closure Compiler to "devDependencies" #866

Closed pioug closed 1 year ago

pioug commented 1 year ago

Describe the bug

Hello, we have recently started to use Branch at BandLab and I notice that we have now Google Closure Compiler as a dependency. Would it be possible to move it to devDependencies instead? That will decrease the installation size

https://github.com/BranchMetrics/web-branch-deep-linking-attribution/blob/master/package.json#L41-L45

image

Steps to reproduce

  1. Run npm install branch-sdk

Expected Behavior

Do not install any package related to Google Closure Compiler

Additional Information/Context

No response

SDK version used (window.branch.sdk)

2.71.0

Environment

macOS 13.1 (it affects any Node package manager)

pioug commented 1 year ago

Fixed in https://github.com/BranchMetrics/web-branch-deep-linking-attribution/pull/905, thanks!